[PATCH 1/7] add-neo1973kbd-jack-state-sys.patch

Andy Green andy at openmoko.com
Tue Sep 23 19:57:14 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| On Mon, Sep 22, 2008 at 08:34:06PM -0300, Werner Almesberger wrote:
|> Andy Green wrote:
|>> @@ -84,6 +108,8 @@ static void neo1973kbd_debounce_jack(struct
work_struct *work)
|>>  		input_report_switch(kbd->input, SW_HEADPHONE_INSERT,
|>>  				    gpio_get_value(irq_to_gpio(kbd->jack_irq)));
|>>  		input_sync(kbd->input);
|>> +		neo1973kbd_jack_event(kbd->cdev,
|>> +				      gpio_get_value(irq_to_gpio(kbd->jack_irq)));
|
|> Redundancy, my nemesis :-( How about doing it like the other buttons do ?
|> E.g., something like this:
|
| FWIW there's a standard jack reporting API which has been merged into
| ALSA and should appear in 2.6.27 or 2.6.28 (can't remember which off the
| top of my head).  It doesn't provide a sysfs interface, just wraps an
| input device ATM.  The intention is that in future it'll be extended or
| wrapped to have hooks into the ASoC power management.

This is also good to know, thanks.

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkjZLfQACgkQOjLpvpq7dMpwlQCgkdkqUBS+AHXG9765RBZboMJY
RoAAnjr2RZDqsLe0kNhJjJEuCCH7rivO
=3LbR
-----END PGP SIGNATURE-----



More information about the openmoko-kernel mailing list