[PATCH 0/9][RFC] GTA02/FreeRunner machine definition for linux-arm-kernel
broonie at opensource.wolfsonmicro.com
Wed Apr 1 19:40:07 CEST 2009
On Tue, Mar 31, 2009 at 10:16:36PM +0100, Ben Dooks wrote:
> My view is that the form of cpu detection mentioned is not necessary
> and any attempts to merge will be severely resisted. I didn't see much
> in this set that really required it anyway.
It'd have been useful if you could have mentioned this on one of the
occasions when I pushed that series; I could then have attempted to
address your concerns and potentially reworked the series to not depend
It's not *essential* since one can always fall back on ifdefs for this
sort of stuff but having cpu_is_*() means that one can build kernels
that target multiple SoCs (this is particularly useful for distro
kernels, especially with SoCS like the S3C6400 and S3C6410 which are
very close). It's also the standard approach for the other ARM ports
which helps code readability for people working over multiple platforms.
Since the check compiles out if the relevant CPU is not supported the
code impact should be minimal.
More information about the openmoko-kernel