Has anyone android working with andy-tracking?

Andy Green andy at openmoko.com
Sun Feb 8 07:00:29 CET 2009

Hash: SHA1

Somebody in the thread at some point said:
| Andy Green wrote:
|> You're right, I don't know where the wake lock code came from or what it
|> really is for either, so we disabled it in config to work around it.
| There's a hint in include/linux/wakelock.h:
| /* A wake_lock prevents the system from entering suspend or other low
|  * states when active. If the type is set to WAKE_LOCK_SUSPEND, the
|  * prevents a full system suspend. If the type is WAKE_LOCK_IDLE, low
|  * states that cause large interrupt latencies or that disable a set of
|  * interrupts will not entered from idle until the wake_locks are
|  */
| Sounds scary, doesn't it ?
| Another clue is in drivers/staging/android/Kconfig:
| |	Enable wakelocks. When user space request a sleep state the
| |	sleep request will be delayed until no wake locks are held.
| Even scarier. Interestingly, I didn't see a peep about this on
| linux-kernel. You'd think that someone proposing this kind of
| klud^H^H^H^Harchitectural enhancement would try to get some serious
| review ...

They're not so scary if they properly default to not impacting suspend
and resume in the case it's not Android running.  I could imagine it's
quite useful to be able to be sure some complex transaction or event is
protected against suspend / resume and atomic for it, since otherwise
it's kind of like FIQ just blasting in there when it feels like it.

The code came in from Michael's patch last week or so, what its status
is for upstream I dunno, since the job is supporting Android it's not
really a problem if it's effectively a local patch in that dir.

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list