[PATCH 4/4] introduce-gta02-beachhead.patch
andy at openmoko.com
Fri Feb 20 10:41:24 CET 2009
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| Andy Green wrote:
|> +config S3C2440_C_FIQ
|> + bool "FIQ ISR support in C"
| I thought you once mentioned that the FIQ code is already on a
| different way to upstream. So do we still need it here ?
|> + select GTA02_HDQ
| Ah, but this one isn't in the tree yet.
Yes these are accidental inclusions, no worries.
Balaji has FIQ refactor coming but it's a separate issue.
| mach-gta02.c is a monster. I think it would be nice to break it
| into more manageable parts. But since this is basically just our
| own private suffering, upstream may not mind if we do this later.
There's no need to worry about this today because we just try to get
this "beachhead", which itself is pretty small. A large chunk is anyway
gone from mach-gta02 to do with HDQ during Balaji's refactor.
I just noticed that the ECC is different from this vanila version than
it is from andy-tracking, when I return to andy-tracking it complains
about "uncorrectable NAND errors" so there is still more to add here.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel