[PATCH 4/4] introduce-gta02-beachhead.patch

[Mark Brown]

On Fri, Feb 20, 2009 at 08:42:50AM +0000, Andy Green wrote:

> +static void mangle_pmu_pdata_by_system_rev(void)
> +{
> +	struct regulator_init_data *reg_init_data =
> +						  gta02_pcf_pdata.reg_init_data;
> +
> +	/* it's not supported any more */
> +	BUG_ON(system_rev == GTA02v1_SYSTEM_REV);

> +	reg_init_data[PCF50633_REGULATOR_LDO1].constraints.min_uV = 3300000;
> +	reg_init_data[PCF50633_REGULATOR_LDO1].constraints.min_uV = 3300000;
> +	reg_init_data[PCF50633_REGULATOR_LDO1].constraints.state_mem.enabled = 0;

> +	reg_init_data[PCF50633_REGULATOR_LDO5].constraints.min_uV = 3000000;
> +	reg_init_data[PCF50633_REGULATOR_LDO5].constraints.max_uV = 3000000;

> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.min_uV = 3000000;
> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.max_uV = 3000000;
> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.apply_uV = 1;
> +}

It looks like the adjustments of the constraints could be removed here
since you only support one possible configuration?

> +static struct i2c_board_info gta02_i2c_devs[] __initdata = {
> +	{
> +		I2C_BOARD_INFO("pcf50633", 0x73),
> +		.irq = GTA02_IRQ_PCF50633,
> +		.platform_data = &gta02_pcf_pdata,
> +	},

You probably want to add the WM8753 here as well.  It should be in here
and I expect to have the WM8753 driver updated to use it by the next
merge window.