[PATCH 4/4] introduce-gta02-beachhead.patch

Andy Green andy at openmoko.com
Sat Feb 21 04:38:05 CET 2009

Hash: SHA1

Somebody in the thread at some point said:

|> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.min_uV = 3000000;
|> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.max_uV = 3000000;
|> +	reg_init_data[PCF50633_REGULATOR_LDO6].constraints.apply_uV = 1;
|> +}
| It looks like the adjustments of the constraints could be removed here
| since you only support one possible configuration?

I just chopped down what we had already without much thought, but don't
these guys turn up in /sys?  We should constrain them if they're settable.

|> +static struct i2c_board_info gta02_i2c_devs[] __initdata = {
|> +	{
|> +		I2C_BOARD_INFO("pcf50633", 0x73),
|> +		.irq = GTA02_IRQ_PCF50633,
|> +		.platform_data = &gta02_pcf_pdata,
|> +	},
| You probably want to add the WM8753 here as well.  It should be in here
| and I expect to have the WM8753 driver updated to use it by the next
| merge window.

Ah we ran into trouble with that somehow when this stuff changed a
couple of Linux versions ago.  As it stands, we instantiate the audio
i2c device inside neo1973_gta02_wm8753.c.  If it's evil, it's fine to
change it since we're only using it because it "works".  But as it
stands it means including neo1973_gta02_wm8753.c in the patchset, is
that aligned to what your plans are in this area?

- -Andy
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org


More information about the openmoko-kernel mailing list