[PATCH 4/4] introduce-gta02-beachhead.patch

Mark Brown broonie at opensource.wolfsonmicro.com
Sat Feb 21 16:11:35 CET 2009

On Sat, Feb 21, 2009 at 11:38:05AM +0800, Andy Green wrote:

> |> +static struct i2c_board_info gta02_i2c_devs[] __initdata = {

> | You probably want to add the WM8753 here as well.  It should be in here
> | and I expect to have the WM8753 driver updated to use it by the next
> | merge window.

> Ah we ran into trouble with that somehow when this stuff changed a
> couple of Linux versions ago.  As it stands, we instantiate the audio
> i2c device inside neo1973_gta02_wm8753.c.  If it's evil, it's fine to
> change it since we're only using it because it "works".  But as it
> stands it means including neo1973_gta02_wm8753.c in the patchset, is
> that aligned to what your plans are in this area?

By the time this hits mainline the WM8753 driver should expect things to
be done that way.

BTW, unless you object I'll create a branch to carry the GTA02 audio
driver for mainline.  I intend to start working actively on it just as
soon as I've found a workflow for the system that works well for me
(for most systems I use netbooting heavily which isn't going to work so
well here).  I'll send patches here as normal, the intention is to have
something sitting ready that I can merge directly into ASoC so it won't
carry any of the underlying code required to actually be usable.  Is
that OK with you?

More information about the openmoko-kernel mailing list