[PATCH 2/3] Move touchscreen filter includes

Nelson Castillo arhuaco at freaks-unidos.net
Sat Jan 17 02:49:26 CET 2009

On Fri, Jan 16, 2009 at 8:18 PM, Werner Almesberger <werner at openmoko.org> wrote:
> Nelson wrote:
>> This patch just moves the touchscreen filter header files
>> around, with no modifications. The kernel will not compile
>> after this patch and another patch will be needed to modify
>> the actual #includes. I read it's better not to modify files
>> when you move them around.
> Yes, but change sets that need more changes before things compile
> again are generally frowned upon because they break git-bisect.
> We're currently living in relatively calm times in the Openmoko kernel
> tree, so Andy may let you get away with this, but better don't make it
> a habit.

I'm sending a patch that does both things. I think this one should be
used instead. I misread this http://kerneltrap.org/node/11765 . I
missed "perhaps with just _trivial_ changes to make it compile".

Thanks for pointing it out.

> I haven't been following what kind of welcome the filter architecture
> got from upstream. Seems that it was friendly ? Congratulations !

Well, nothing from linux-input. In LKML Andrew Morton just told us to
fix a few things. I think it is a good thing that nobody has told us
that we suck, not yet :-)

We need to submit code that actually uses the filters before they
accept the patches upstream. Right now s3c2410_ts.c and mach-gta02.c
come to my mind (I am not aware of the dependencies).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-filter-includes.patch
Type: text/x-patch
Size: 19157 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20090116/c0f9345c/attachment-0001.bin 

More information about the openmoko-kernel mailing list