[PATCH] fix GPS resume if powered on previously
andy at openmoko.com
Mon Jan 19 11:47:54 CET 2009
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| Andy Green wrote:
|> Somebody in the thread at some point said:
|> | Fix re-enabling of GPS on resume: the call to gps_pwron_set(0) during
|> | would clear power_was_on flag so the on/off status was always lost.
|> As you predicted neither of these patches will apply after Werner's
|> What is the value of allowing leaving GPS up in suspend, this is just so
|> you don't have to wait out the TTFF again? Is there a particular
|> scenario someone will select this option?
| Yes, instant fix on resume. The power consumption of the GPS is not
| and there are people who prefer instant fix on resume to a bit longer
| lifetime (geocachers would agree - you can safely let the phone
| still have exacpt position on resume (this could even lead to longer
| in the end)).
| Additionally you can get a fix when you walk inside - which probably won't
| work otherwise.
Fine, if it's not too much hassle could you uplevel those patches to
current HEAD and I'll take them?
|> Also, although it sounds right we should repower GPS on resume if it was
|> powered before, it will lose state like selection of the binary format
|> and so on when it recovers. So it will need some support for this in
|> userspace somehow.
| That's right - but until there is such tool in all distros... (on the
| hand - how many apps do use anything else than NMEA? :)
Ah there's some stuff by Daniel that uses the UBX stuff for the assisted
mode, I think it is out there and in use. Whether it just sets UBX mode
I don't really know, but I guess if it does it could react to seeing
NMEA by sending the UBX mode packet again.
Anyway it's not hurting your code allowing it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel