[PATCH] add comment on register cache initial values to codecs/wm8753.c

Timo Juhani Lindfors timo.lindfors at iki.fi
Tue Jan 20 21:13:14 CET 2009


while reading through the sound code it took me a while to figure out
where the initial values of the register cache come from. (It took a
while since the spec shows them as 9-bit binary numbers while the
source uses 16-bit hexadecimal constants...)

Not sure how useful this is but the following comment might help
others find this faster :-)

diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index 8ede5bd..5911bd9 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -70,6 +70,7 @@ struct wm8753_priv {
  * wm8753 register cache
  * We can't read the WM8753 register space when we
  * are using 2 wire for device control, so we cache them instead.
+ * Initial values are from page 77 of the WM8753L datasheet.
 static const u16 wm8753_reg[] = {
        0x0008, 0x0000, 0x000a, 0x000a,

best regards,
Timo Lindfors

More information about the openmoko-kernel mailing list