[PATCH] qi: initialize PMU GPIOs
andy at openmoko.com
Sat Jan 24 13:40:13 CET 2009
-----BEGIN PGP SIGNED MESSAGE-----
Somebody in the thread at some point said:
| Werner Almesberger <werner at openmoko.org> writes:
|> thanks for reporting this critter. Can you please test the patch
|> below ?
| I originally discovered this issue and can confirm that the patch
| works. Kernel sysfs driver is still not exactly correct though, as it
| sets 0x15 to 0x01 (reserved) instead of 0x07 (fixed 1).
Maybe we can fix that and add a Reported-by: for Paul, otherwise it
looks like a good bugfix.
Another issue though is that for determinism, really the kernel driver
should arguably assert all the needed state for the default at kernel
startup and not leave it to be inherited by the bootloader as we have
previously done. Really the defaults in hardware should be designed to
be sane already (ie, pull that line down not up) so the bootloader is
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel