[PATCH] Send pen-up events faster (side effect: improve illume keyboard responsiveness)

Nelson Castillo arhuaco at freaks-unidos.net
Thu Jan 29 10:48:59 CET 2009


From: Nelson Castillo <arhuaco at freaks-unidos.net>

We were waiting 60ms before reporting a pen-up event to avoid
jitter. Now we wait 8ms (actually 5 with HZ == 200).

Thanks to Marco Trevisan for testing and pointing out that there was a
problem that could be spotted with the illume keyboard.
Note that I used the Terminal mode of the keyboard (no dictionary)
for tests.

I also used touch_test.py and the jitter doesn't seem to be an
issue when drawing lines with the finger.

Reported-by: Marco Trevisan (Treviño) <mail at 3v1n0.net>
Signed-off-by: Nelson Castillo <arhuaco at freaks-unidos.net>
---

 drivers/input/touchscreen/s3c2410_ts.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index 1a930a2..ea0777c 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -96,7 +96,7 @@ MODULE_LICENSE("GPL");
 
 static char *s3c2410ts_name = "s3c2410 TouchScreen";
 
-#define TS_RELEASE_TIMEOUT (HZ >> 4)		/* ~ 60 milliseconds */
+#define TS_RELEASE_TIMEOUT (HZ >> 7 ? HZ >> 7 : 1) /* 8ms (5ms if HZ is 200) */
 #define TS_EVENT_FIFO_SIZE (2 << 6) /* must be a power of 2 */
 
 #define TS_STATE_STANDBY 0 /* initial state */




More information about the openmoko-kernel mailing list