[PATCH] ASoC: Fix wm8753 register cache size and initialization

Lars-Peter Clausen lars at metafoo.de
Fri Jul 3 13:07:42 CEST 2009

Mark Brown wrote:
> I've published a fix for this one, see below
>> This could be related to the 'heisenbug' reported in
>> http://docs.openmoko.org/trac/ticket/1172
> No, that predates the change in the driver by a very long time.
Sorry, I should have been more clear what part of the patch is related 
to the heisenbug:
I suspect the heisenbug to be caused by the register cache being one to 
small and in the openmoko tree version of wm8753.c the bounds check in 
the register cache access code is wrong and allows access to one element 
behind the actual array size.
So read/write to the WM8753_ADCTL2 register accesses unalloced and 
uninitalised memory. Which explains why it showed up only sometimes.

- Lars

More information about the openmoko-kernel mailing list