[RFC] pcf50633-charger: Revert ad99a335ca77d81173140187fe20a946b0c309af, 3e96d0a35a3a1e2c7cfef77ec47a63d1f61467dc and 819eb8196422f5fbe19690c903093ccc37519227

Rask Ingemann Lambertsen ccc94453 at vip.cybercity.dk
Wed Jul 29 17:41:38 CEST 2009


   These three patches went into drivers/power_supply/pcf50633-charger.c:

http://git.openmoko.org/?p=kernel.git;a=commitdiff;h=ad99a335ca77d81173140187fe20a946b0c309af
commit ad99a335ca77d81173140187fe20a946b0c309af
Author: Balaji Rao <balajirrao at openmoko.org>
Date:   Wed Jan 28 19:31:11 2009 +0000

    Subject: pcf50633_introduce_charging_restart_interval.patch
    X-Git-Url: http://git.openmoko.org/?p=kernel.git;a=commitdiff_plain;h=1bb6adaa6a59f52d616b5260cb776eafd40ef05e
    
    pcf50633_introduce_charging_restart_interval.patch
    
    Signed-off-by: Balaji Rao <balajirrao at openmoko.org>

http://git.openmoko.org/?p=kernel.git;a=commitdiff;h=3e96d0a35a3a1e2c7cfef77ec47a63d1f61467dc
commit 3e96d0a35a3a1e2c7cfef77ec47a63d1f61467dc
Author: Balaji Rao <balajirrao at openmoko.org>
Date:   Mon Dec 29 12:11:35 2008 +0000

    Kill automatic charging restart to retain manual control.
    
    Signed-off-by: Balaji Rao <balajirrao at openmoko.org>

http://git.openmoko.org/?p=kernel.git;a=commitdiff;h=819eb8196422f5fbe19690c903093ccc37519227
commit 819eb8196422f5fbe19690c903093ccc37519227
Author: Balaji Rao <balajirrao at openmoko.org>
Date:   Mon Dec 29 12:11:33 2008 +0000

    Manually restart charger periodically
    
    This avoids excessive discharges seen in case of Li-ion batteries even
    when charger is connected.
    
    Signed-off-by: Balaji Rao <balajirrao at openmoko.org>


   The patches were supposed to fix part of (non-)bug 1158:
https://docs.openmoko.org/trac/ticket/1158#comment:56

   The patches simply don't work, so I suggest they be reverted. Here's how I
tested - you may want to s/180/600/ so it runs longer or increase
vibrator intensity so it discharges faster:

# echo >/sys/class/leds/neo1973\:vibrator/brightness 50
# for i in {0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9}; do sleep 180 && echo \
$(date; cat /sys/class/power_supply/battery/{capacity,{voltage,current}_now}); \
done

   Clearly the charger is not restarted after 15 minutes:

Wed Jul 29 01:33:51 CEST 2009 93 4094000 23062
Wed Jul 29 01:36:52 CEST 2009 93 4094000 23062
Wed Jul 29 01:39:53 CEST 2009 93 4091000 22875
Wed Jul 29 01:42:54 CEST 2009 93 4091000 22875
Wed Jul 29 01:45:55 CEST 2009 93 4091000 22875
Wed Jul 29 01:48:56 CEST 2009 93 4088000 23062
Wed Jul 29 01:51:57 CEST 2009 93 4088000 22875
Wed Jul 29 01:54:59 CEST 2009 93 4088000 23062
Wed Jul 29 01:58:01 CEST 2009 93 4086000 23062
Wed Jul 29 02:01:02 CEST 2009 93 4086000 23062
Wed Jul 29 02:04:03 CEST 2009 92 4086000 23062
Wed Jul 29 02:07:04 CEST 2009 92 4083000 22875
Wed Jul 29 02:10:08 CEST 2009 92 4083000 22875
Wed Jul 29 02:13:14 CEST 2009 92 4083000 22875
Wed Jul 29 02:16:17 CEST 2009 92 4083000 22875
Wed Jul 29 02:19:19 CEST 2009 92 4081000 22875
Wed Jul 29 02:22:20 CEST 2009 92 4081000 22875
Wed Jul 29 02:25:21 CEST 2009 92 4081000 22875
Wed Jul 29 02:28:22 CEST 2009 92 4078000 23062
Wed Jul 29 02:31:24 CEST 2009 92 4078000 23062
Wed Jul 29 02:34:25 CEST 2009 92 4078000 23062
Wed Jul 29 02:37:26 CEST 2009 91 4075000 23062
Wed Jul 29 02:40:27 CEST 2009 91 4075000 23062
Wed Jul 29 02:43:29 CEST 2009 91 4075000 23062
Wed Jul 29 02:46:30 CEST 2009 91 4075000 23062
Wed Jul 29 02:49:31 CEST 2009 91 4073000 23062
Wed Jul 29 02:52:32 CEST 2009 91 4073000 23062
Wed Jul 29 02:55:33 CEST 2009 91 4073000 23062
Wed Jul 29 02:58:34 CEST 2009 91 4070000 23062
Wed Jul 29 03:01:36 CEST 2009 91 4070000 23062
Wed Jul 29 03:04:37 CEST 2009 90 4070000 23062
Wed Jul 29 03:07:38 CEST 2009 90 4070000 23062
Wed Jul 29 03:10:39 CEST 2009 90 4068000 23062
Wed Jul 29 03:13:40 CEST 2009 90 4068000 23062
Wed Jul 29 03:16:41 CEST 2009 90 4068000 23062
Wed Jul 29 03:19:42 CEST 2009 90 4065000 23062
Wed Jul 29 03:22:44 CEST 2009 90 4065000 23062
Wed Jul 29 03:25:45 CEST 2009 90 4065000 23062
Wed Jul 29 03:28:46 CEST 2009 90 4062000 23062
Wed Jul 29 03:31:47 CEST 2009 90 4062000 23062
Wed Jul 29 03:34:48 CEST 2009 89 4062000 22875
Wed Jul 29 03:37:49 CEST 2009 89 4062000 23062
Wed Jul 29 03:40:51 CEST 2009 89 4060000 23062
Wed Jul 29 03:43:52 CEST 2009 89 4060000 23062
Wed Jul 29 03:46:53 CEST 2009 89 4060000 23062
Wed Jul 29 03:49:54 CEST 2009 89 4057000 23062
Wed Jul 29 03:52:55 CEST 2009 89 4057000 23062
Wed Jul 29 03:55:56 CEST 2009 89 4057000 23062
Wed Jul 29 03:58:58 CEST 2009 89 4054000 23062
Wed Jul 29 04:01:59 CEST 2009 89 4054000 23062
Wed Jul 29 04:05:00 CEST 2009 88 4054000 23062
Wed Jul 29 04:08:01 CEST 2009 88 4054000 23062
Wed Jul 29 04:11:02 CEST 2009 88 4052000 23062
Wed Jul 29 04:14:04 CEST 2009 88 4052000 23250
Wed Jul 29 04:17:05 CEST 2009 88 4052000 23250
Wed Jul 29 04:20:06 CEST 2009 88 4052000 23062
Wed Jul 29 04:23:07 CEST 2009 88 4049000 23062
Wed Jul 29 04:26:08 CEST 2009 88 4049000 23062
Wed Jul 29 04:29:10 CEST 2009 88 4049000 23250
Wed Jul 29 04:32:11 CEST 2009 88 4047000 23062
Wed Jul 29 04:35:12 CEST 2009 88 4047000 23250
Wed Jul 29 04:38:13 CEST 2009 87 4047000 23062
Wed Jul 29 04:41:14 CEST 2009 87 4047000 23062
Wed Jul 29 04:44:16 CEST 2009 87 4044000 23062
Wed Jul 29 04:47:17 CEST 2009 87 4044000 22875
Wed Jul 29 04:50:18 CEST 2009 87 4044000 23062
Wed Jul 29 04:53:19 CEST 2009 87 4041000 23062
Wed Jul 29 04:56:20 CEST 2009 87 4041000 23062
Wed Jul 29 04:59:21 CEST 2009 87 4041000 23062
Wed Jul 29 05:02:22 CEST 2009 87 4041000 23062
Wed Jul 29 05:05:24 CEST 2009 86 4039000 23062
Wed Jul 29 05:08:25 CEST 2009 86 4039000 23062
Wed Jul 29 05:11:26 CEST 2009 86 4039000 23062
Wed Jul 29 05:14:27 CEST 2009 86 4036000 23062
Wed Jul 29 05:17:28 CEST 2009 86 4036000 23062
Wed Jul 29 05:20:29 CEST 2009 86 4036000 22875
Wed Jul 29 05:23:31 CEST 2009 86 4036000 22875
Wed Jul 29 05:26:32 CEST 2009 86 4034000 23062
Wed Jul 29 05:29:33 CEST 2009 86 4034000 23062
Wed Jul 29 05:32:34 CEST 2009 86 4034000 23062
Wed Jul 29 05:35:35 CEST 2009 85 4034000 23062
Wed Jul 29 05:38:36 CEST 2009 85 4031000 22875
Wed Jul 29 05:41:38 CEST 2009 85 4031000 23062
Wed Jul 29 05:44:39 CEST 2009 85 4031000 23062
Wed Jul 29 05:47:40 CEST 2009 85 4028000 23062
Wed Jul 29 05:50:41 CEST 2009 85 4028000 23062
Wed Jul 29 05:53:42 CEST 2009 85 4028000 23062
Wed Jul 29 05:56:43 CEST 2009 85 4028000 22875
Wed Jul 29 05:59:45 CEST 2009 85 4026000 23062
Wed Jul 29 06:02:46 CEST 2009 85 4026000 22875
Wed Jul 29 06:05:47 CEST 2009 84 4026000 23062
Wed Jul 29 06:08:48 CEST 2009 84 4023000 22875
Wed Jul 29 06:11:49 CEST 2009 84 4023000 23062
Wed Jul 29 06:14:51 CEST 2009 84 4023000 23062
Wed Jul 29 06:17:52 CEST 2009 84 4023000 22875
Wed Jul 29 06:20:53 CEST 2009 84 4021000 23062
Wed Jul 29 06:23:54 CEST 2009 84 4021000 23062
Wed Jul 29 06:26:55 CEST 2009 84 4021000 27000
Wed Jul 29 06:29:56 CEST 2009 84 4018000 27000
Wed Jul 29 06:32:58 CEST 2009 83 4018000 29625

   Fortunately, the patch to disable the automatic charging in the PMU isn't
working either - would've been great while suspended - , as this was the
result when I got back to the Neo several hours later:

# cat /sys/class/power_supply/battery/{{current,voltage}_now,capacity}
-4687
4161000
100

   So we can simply revert all three patches.

-- 
Rask Ingemann Lambertsen
Danish law requires addresses in e-mail to be logged and stored for a year



More information about the openmoko-kernel mailing list