[PATCH] GTA0[12]: make headset button report PLAY pressed on press

Nelson Castillo arhuaco at freaks-unidos.net
Tue Jun 9 07:28:20 CEST 2009

On Mon, Jun 8, 2009 at 4:46 PM, Paul Fertser<fercerpav at gmail.com> wrote:
> As discussed on the ML, currently headset button reports "KEY_PAUSE
> released" on press and "pressed" on release. For "pause" semantics it makes
> sense but if someone thinks of that as of just another button, it'd be good
> to have "pressed/released" events consistent with button press/release.
> Luca Capello <luca at pca.it> suggested to change the button event to KEY_PLAY
> and to invert the state to make it more consistent.
> This trivial patch inverts button events for GTA03 KEY_PLUS and KEY_MINUS,
> i'm not sure how undesirable that is. I can prepare an alternative that
> preserves current behaviour on GTA03 per request.

Hello Paul.

I don't think we should care much about gta03 now. Let's wait a little
(not much) for more comments before applying your patch.


More information about the openmoko-kernel mailing list