[PATCH] GTA0[12]: make headset button report PLAY pressed on press

Joerg Reisenweber joerg at openmoko.org
Tue Jun 9 15:02:52 CEST 2009


Am Di  9. Juni 2009 schrieb Luca Capello:
> Hi there!
> 
> First post to this list, so welcome everybody :-)
> 
> Please Cc: me, I do not read the list.
> 
> On Tue, 09 Jun 2009 07:28:20 +0200, Nelson Castillo wrote:
> > On Mon, Jun 8, 2009 at 4:46 PM, Paul Fertser<fercerpav at gmail.com> wrote:
> >> As discussed on the ML, currently headset button reports "KEY_PAUSE
> >> released" on press and "pressed" on release. For "pause" semantics it 
makes
> >> sense but if someone thinks of that as of just another button, it'd be 
good
> >> to have "pressed/released" events consistent with button press/release.
> >>
> >> Luca Capello <luca at pca.it> suggested to change the button event to 
KEY_PLAY
> >> and to invert the state to make it more consistent.
> >>
> >> This trivial patch inverts button events for GTA03 KEY_PLUS and 
KEY_MINUS,
> >> i'm not sure how undesirable that is. I can prepare an alternative that
> >> preserves current behaviour on GTA03 per request.
> [...]
> > I don't think we should care much about gta03 now. Let's wait a little
> > (not much) for more comments before applying your patch.
> 
> Note that this has nothing to do with GTA03, but it was discovered on
> both GTA01 and GTA02, please read the thread at
> 
>   
http://thread.gmane.org/gmane.comp.hardware.smartphones.userland/1296/focus=1310
> 
> As Enrico Zini pointed out in the same thread, what is the reason for
> the button being reported as pressed when it is not physically pressed?
> 
> Thx, bye,
> Gismo / Luca
> 

Luca
[please don't answer to a msg to start a new thread]
is your question about this?:
http://docs.openmoko.org/trac/ticket/2209

cheers
jOERG
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://lists.openmoko.org/pipermail/openmoko-kernel/attachments/20090609/41d8fc63/attachment.pgp 


More information about the openmoko-kernel mailing list