[PATCH] GTA0[12]: make headset button report PLAY pressed on press

Nelson Castillo arhuaco at freaks-unidos.net
Wed Jun 10 02:34:50 CEST 2009


2009/6/9 Paul Fertser <fercerpav at gmail.com>:
> Nelson Castillo <nelsoneci at gmail.com> writes:
>>> Signed-off-by: Paul Fertser <fercerpav at gmail.com>
>>>        [NEO1973_KEY_HOLD] = {
>>>                .name = "Neo1973 HOLD button",
>>>                .isr = neo1973kbd_default_key_irq,
>>> -               .input_key = KEY_PAUSE,
>>> +               .input_key = KEY_PLAY,
>>
>>
>> Will this change confuse existing Apps?
>
> If there're any, yes, they will miss buttons events. OTOH so far
> nobody on devel ML complained.

Paul, Sent. checkpatch complains about a line with more than 80 chars
(81) but in this case the fix is ugly.



More information about the openmoko-kernel mailing list