[RFC patch pcf50633-core] Android resume on one click patch

Michael Trimarchi trimarchi at gandalf.sssup.it
Thu Mar 19 22:14:18 CET 2009


Werner Almesberger wrote:
> Michael Trimarchi wrote:
>>  		/* Make sure we don't pass on any ONKEY events to
>>  		 * userspace now */
>> +#ifndef CONFIG_MFD_PCF50633_ANDROID
>>  		pcf_int[1] &= ~(PCF50633_INT2_ONKEYR | PCF50633_INT2_ONKEYF);
>> +#endif
>> +
> Hmm, I wonder if we couldn't avoid having two subtly different
> behaviours selected at compile-time. If you think of it, there
> must be millions of similar choices in the kernel. If we had a
> config option for each of them, ...
> First of all, couldn't the entity in Android that commands the
> suspend just get the wakeup reason and generate the onkey event ?
I can look in this, but is there any reason to don't generate the keyboard
event, is it a standard behavior having the reason but not having the event?
If it is not a problem, can we remove it and change the beahvior? and 
remove an
eventually config option?
> - Werner

More information about the openmoko-kernel mailing list