[PATCH] Clean up pcf50606_client_dev_register

Werner Almesberger werner at openmoko.org
Thu Mar 26 06:58:57 CET 2009


tim.niemeyer at mastersword.de wrote:
> platform_device_add_data copies the data, so no need for
> kmalloc.

Agreed. And neither did we need the memory leak :-)

It's still somewhat contorted (why take the detour with "struct
pcf50606_subdev_pdata" and not just use "struct pcf5606" ?), but
better.

It's in andy-tracking.

Thanks,
- Werner



More information about the openmoko-kernel mailing list