Missing CONFIG_BACKLIGHT_PCF50633 Kconfig entry
lars at metafoo.de
Tue Nov 10 02:22:36 CET 2009
-----BEGIN PGP SIGNED MESSAGE-----
Marc Andre Tanner wrote:
> On Tue, Nov 10, 2009 at 01:42:43AM +0100, Lars-Peter Clausen wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> Marc Andre Tanner wrote:
>>> Hi Lars,
>>> I am testing the om-gta02-2.6.31 kernel branch -- nice work!
>>> I noticed that CONFIG_BACKLIGHT_PCF50633 is not referenced in
>> Kconfig file
>>> but used in a Makefile.
>>> $ grep -r CONFIG_BACKLIGHT_PCF50633 *
>> += pcf50633-backlight.o
>>> This causes some problems for example if one wants to generate
>> miniconfig file
>>> which contains only the minimal required options for use with:
>>> make allnoconfig KCONFIG_ALLCONFIG="miniconfig"
>>> The script which generates those miniconfig files uses the
>> build infrastructure
>>> and it's dependency information from the various Kconfig files
>> because there is no
>>> entry found the option is dropped which results in a build
>>> Could you please add an entry or a select statement for
>> CONFIG_BACKLIGHT_PCF50633 to
>>> the apropriate Kconfig file?
>>> Thanks, Marc
>> Hi Marc
>> Thanks for your feedback, should be fixed now.
> Thanks, as far as I can see you fixed the build failure if the
> backlight driver isn't compiled in.
> However wouldn't a Kconfig entry still be useful so it turns up
> under make menuconfig?
Um, there is one under drivers/video/backlight/Kconfig
> For my problem with the miniconfig genereation a simple "select
> BACKLIGHT_PCF50633" in the appropriate Kconfig file would work.
> This would ensure that it's reconiced as a required option and kept
> in generated miniconfig file.
Well, the backlight driver is not required, so I don't think it's a
good idea to select it by the machine. That's what we have default
- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the openmoko-kernel