[PATCH 3/8] s3c24xx: introduce s3c-adc delay

Nelson Castillo arhuaco at freaks-unidos.net
Wed Sep 23 11:51:33 CEST 2009


On Tue, Sep 22, 2009 at 5:25 AM, Nelson Castillo
<arhuaco at freaks-unidos.net> wrote:
> On Tue, Sep 22, 2009 at 5:23 AM, Nelson Castillo
> <arhuaco at freaks-unidos.net> wrote:
>> From: Vasily Khoruzhick <anarsoul at gmail.com>
>>
>> Without this patch we cannot make the s3c2410/s3c2440 touchscreen
>> driver work.
>>
>> Is this delay device-dependant?
>> Is there a better way to do this?
>
> I really wonder if this is how we should be adding the delay.


While preparing patches I think that what we have now as

struct s3c2410_ts_info {
        int delay;
        int presc;
};

Should actually be s3c-adc platform data. The new s3c2440_ts driver
doesn't use these values.... I wonder if the ADC can change its delay
and its prescaler value before attending a specific ADC client. I
don't think this is the case. I guess I should ask in linux-arm-kernel
later or just assume we need s3c_adc_platdata and send the patches...

Thoughts?



More information about the openmoko-kernel mailing list