[PATCH] uboot-hxd8-nand-chip-select.patch

[Eric Chen]

Hi, Harald,

You're right, I updated the patch again.
Regards,
Eric
----- Original Message ----- 
From: "Harald Welte" <laforge at openmoko.org>
To: "Eric Chen" <eric_chen at fiwin.com.tw>
Cc: <openmoko-uboot at lists.openmoko.org>
Sent: Thursday, May 31, 2007 5:49 PM
Subject: Re: [PATCH] uboot-hxd8-nand-chip-select.patch


> On Tue, May 29, 2007 at 10:49:35AM +0800, Eric Chen wrote:
>> Hi, Harald,
>>
>> I added minimum changes to make it work.
>> (1) select_chip is mandatory.
>
> I disagree.  This basically circumvents the standard method of selecting
> different MTD devices (CFG_NAND_SELECT_DEVICE and the
> board_nand_select_device() callback).  If this is not working, then we
> need to debug why it is not working, rather than just abandoning the
> standard method and doing it our own way.
>
>> (2) nand_curr_device should be selected before nand_init.
>
> This once again should not be required if we manage to get the
> select_device method working.
>
> Please investigate,
> -- 
> - Harald Welte <laforge at openmoko.org> 
> http://openmoko.org/
> ============================================================================
> Software for the world's first truly open Free Software mobile phone 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand-repatch
Type: application/octet-stream
Size: 908 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/openmoko-uboot/attachments/20070601/44be6683/nand-repatch.obj