[Bug 512] New: moko_scrolled_pane_get_scrolled_window is bad API

[bugzilla-daemon at bugzilla.openmoko.org]

http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=512

           Summary: moko_scrolled_pane_get_scrolled_window is bad API
           Product: OpenMoko
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: openmoko-libs
        AssignedTo: mickey at vanille-media.de
        ReportedBy: rob at o-hand.com
                CC: buglog at lists.openmoko.org,thomas at openedhand.com


I assume the point of this function is to get the scrolled window so that one
can add a widget to it, e.g. a TreeView. This seems pretty bad since you are
exposing some of the internals. I 

Having consulted with my resident GTK hacker he would suggest adding a

void moko_scrolled_pane_pack (MokoScrolledPane *pane, GtkWidget *child)
and
void moko_scrolled_pane_unpack (MokoScrolledPane *pane, GtkWidge *child)
and
GtkWidget *moko_scrolled_pane_get_child (MokoScrolledPane *pane)

Code ready to commit when you say so.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.