[Bug 631] New: [Patch/Cleanup] No segfault when dbus not running

[bugzilla-daemon at bugzilla.openmoko.org]

http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=631

           Summary: [Patch/Cleanup] No segfault when dbus not running
           Product: OpenMoko
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: openmoko-dialer
        AssignedTo: thomas at openedhand.com
        ReportedBy: elrond+bugzilla.openmoko.org at samba-tng.org
                CC: buglog at lists.openmoko.org


The dialer can segfault, when there is no dbus running/runnable.

The main problem is calling org_freedesktop_DBus_request_name with proxy==NULL
and later looking at error (which is not properly set).

This patch stops this and factors the dbus setup partly out of main().

It also lets the dialer work _somewhat_ in this situation. That means, that the
dialer pops up immediately (so it can be used at all).
Letting the dialer work in this situation should not be considered a problem:
* The changes needed to get this "feature" are minimal and non-invasive
* They don't hurt
* This is not a standard situation, so if the "feature" later breaks,
  it does't hurt either.
  (read: Nobody should care to hold this feature working)

In one sentence: It's currently "free" and involves no later "costs".



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.