[Bug 840] Lack of CalledID on incoming calls when phone send it

bugzilla-daemon at bugzilla.openmoko.org bugzilla-daemon at bugzilla.openmoko.org
Wed Oct 10 13:51:14 CEST 2007


http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=840

Tuukka.Hastrup at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Tuukka.Hastrup at iki.fi



------- Additional Comments From Tuukka.Hastrup at iki.fi  2007-10-10 13:51 -------
While I was testing the dialer, I had a look at this too. First incoming call
after gsmd restart shows the caller:

** (openmoko-dialer:1431): DEBUG: mokogsmd setup
EVENT: Incoming Call Progress: SETUP
** (openmoko-dialer:1431): DEBUG: mokogsmd setup
EVENT: Incoming Call Progress: SETUP
EVENT: Incoming call type = 2
EVENT: Incoming call clip = "+358405922923"
EVENT: Incoming Call Progress: SYNC
** (openmoko-dialer:1431): DEBUG: Playing 
** (openmoko-dialer:1431): DEBUG: Incoming Number = "+358405922923"
** (openmoko-dialer:1431): DEBUG: mokogsmd sync
** (openmoko-dialer:1431): DEBUG: Playing done

Second incoming call from the same number doesn't show the caller:

** (openmoko-dialer:1431): DEBUG: mokogsmd setup
EVENT: Incoming Call Progress: SETUP
** (openmoko-dialer:1431): DEBUG: mokogsmd setup
** (openmoko-dialer:1431): DEBUG: Playing
** (openmoko-dialer:1431): DEBUG: mokogsmd sync
EVENT: Incoming Call Progress: SETUP
EVENT: Incoming call type = 2
EVENT: Incoming call clip = "+358405922923"
EVENT: Incoming Call Progress: SYNC
** (openmoko-dialer:1431): DEBUG: Playing done
** (openmoko-dialer:1431): DEBUG: Playing
** (openmoko-dialer:1431): DEBUG: 1500 timeout
** (openmoko-dialer:1431): DEBUG: Playing done

In both cases, gsmd prints the "clip", but in the second case, openmoko-dialer
doesn't. 

The issue seems to be the logic in moko-dialer.c function on_incoming_clip.
There, GDK_CURRENT_TIME is used as if it was an actual time value, although it's
defined as 0L. Thus, the time stamp should be gotten some other way for this to
work as intended.

Further, some other means than checking for time difference < 1500 ms could be
more meaningful. I mean, is what we want something like "always send the CLIP if
one wasn't sent for this call already"?




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the buglog mailing list