Openmoko Bug #2155: opkg-native do_compile failed

[Openmoko Public Trac]

#2155: opkg-native do_compile failed
---------------------+------------------------------------------------------
 Reporter:  manitu   |          Owner:  tick                                                                                                        
     Type:  defect   |         Status:  accepted                                                                                                    
 Priority:  high     |      Milestone:                                                                                                              
Component:  opkg     |        Version:                                                                                                              
 Severity:  blocker  |       Keywords:  opkg opkg-native do_compile SUSE11.0 compile error free_error_list opkh_cmd.c opkg_cmd opkg_print_error_list
 Haspatch:  1        |      Blockedby:                                                                                                              
Estimated:           |    Patchreview:                                                                                                              
 Blocking:           |   Reproducible:  always                                                                                                      
---------------------+------------------------------------------------------

Comment(by tick):

 Yes, this indeed is a bug. Thanks for reporting this.
 It was defined as:
 In file ./opkg_utils.h
 26:void free_error_list();

 but the usage becomes
 free_error_list(&error_list);
 That's wrong.

 fix in svn 4844

 you can patch the following patch to 4640 as well
 commit ba0825094571b051edbf35f8f8bffe02c388d1af
 Author: tick <tick at 99fdad57-331a-0410-800a-d7fa5415bdb3>
 Date:   Wed Dec 3 15:33:52 2008 +0000

     opkg: remove the free_error_list wrong usage bug
     Thanks for manitu


     git-svn-id: https://svn.openmoko.org/trunk/src/target/opkg@4844
 99fdad57-331a-0410-800a-d7fa5415bdb3

 diff --git a/libopkg/opkg_cmd.c b/libopkg/opkg_cmd.c
 index cf1cc5d..5b842bd 100644
 --- a/libopkg/opkg_cmd.c
 +++ b/libopkg/opkg_cmd.c
 @@ -151,7 +151,7 @@ void opkg_print_error_list (opkg_conf_t *conf)
             error_list = error_list->next;

       }
 -     free_error_list(&error_list);
 +     free_error_list();
    }

  }

-- 
Ticket URL: <https://docs.openmoko.org/trac/ticket/2155#comment:7>
docs.openmoko.org <http://docs.openmoko.org/trac/>
openmoko trac