[Bug 1187] chgstate gives incorrect output (fix)

bugzilla-daemon at bugzilla.openmoko.org bugzilla-daemon at bugzilla.openmoko.org
Fri Jan 18 08:16:29 CET 2008


------- Additional Comments From mail at mmontour.net  2008-01-18 08:16 -------
Created an attachment (id=500)
 --> (http://bugzilla.openmoko.org/cgi-bin/bugzilla/attachment.cgi?id=500&action=view)
Another possible fix for this issue

In the previous patch, shouldn't the "i < ARRAY_SIZE(chgstate_names)" also be
changed to "(1<<i) < ARRAY_SIZE(chgstate_names)"?

I also don't think it's good for chgstate_names to be a sparse array (maximum
array index of 32 (0x20) but only 6 non-NULL elements). I am attaching a patch
that fixes this by defining new symbols for the bit-positions of the various
PCF50606_F_CHG_ flags (0 to 5). 

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the buglog mailing list