[Bug 788] Starting or stopping gsmd completely locks up the Neo

[bugzilla-daemon at bugzilla.openmoko.org]

http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=788

werner at openmoko.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |werner at openmoko.org



------- Additional Comments From werner at openmoko.org  2008-01-22 00:04 -------
Shouldn't just resetting flow control when switching away from / powering down
the modem solve the problem at hand ?

I don't think we absolutely have to preserve flow control state, since gsmd
can very well take care of setting it up upon restart. If someone sets flow
control by accident, well, that's called tragic pilot error :-)

If I had to choose between the two patches, I'd prefer Fabien's, because it's
less intrusive. However, I'd be even happier with a patch that just clears
the darn flow control bit (in the platform-specific code).

Any takers ?

Getting rid of the potential endless loop is a different issue, and certainly
a worthwhile endeavour. (I'd suggest to find a suitable time source, then
loop until a configurable amount of time has passed, and then setting a flag
that disables further looping, until the UART becomes operational again).

I.e.,

static int stuck = 0;

do ok = ready();
while (!stuck && !ok && !timeout())
if (!ok) {
        stuck = 1;
        return;
}
stuck = 0;



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.