r2682 - in trunk/src/target/OM-2007.2/applications/openmoko-feedreader2: . src
zecke at sita.openmoko.org
zecke at sita.openmoko.org
Fri Aug 10 04:16:51 CEST 2007
Author: zecke
Date: 2007-08-10 04:16:49 +0200 (Fri, 10 Aug 2007)
New Revision: 2682
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.c
Log:
2007-08-10 Holger Hans Peter Freyther <zecke at selfish.org>
Untested change to save some space in the initial view. Move the
update feed button from a GtkToolbar to the GtkHBox in the 'second'
row.
This saves a lot of real estate on the screen but the button has no
label violating 'Fitts Law'. Others have to decide...
* src/feed-selection-view.c:
(feed_selection_view_init):
Modified: trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/ChangeLog 2007-08-10 01:33:12 UTC (rev 2681)
+++ trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/ChangeLog 2007-08-10 02:16:49 UTC (rev 2682)
@@ -1,3 +1,14 @@
+2007-08-10 Holger Hans Peter Freyther <zecke at selfish.org>
+
+ Untested change to save some space in the initial view. Move the
+ update feed button from a GtkToolbar to the GtkHBox in the 'second'
+ row.
+ This saves a lot of real estate on the screen but the button has no
+ label violating 'Fitts Law'. Others have to decide...
+
+ * src/feed-selection-view.c:
+ (feed_selection_view_init):
+
2007-08-06 Holger Hans Peter Freyther <zecke at selfish.org>
At least give some 'label' to the button without a meaningful icon.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.c 2007-08-10 01:33:12 UTC (rev 2681)
+++ trunk/src/target/OM-2007.2/applications/openmoko-feedreader2/src/feed-selection-view.c 2007-08-10 02:16:49 UTC (rev 2682)
@@ -149,23 +149,17 @@
view->filter = RSS_FEED_FILTER (feed_filter_new (RSS_FEED_DATA (feed_data_get_instance ())));
view->sort = RSS_FEED_SORT (feed_sort_new (view->filter));
- /*
- * toolbar
- */
- GtkWidget* toolbar = gtk_toolbar_new ();
- gtk_box_pack_start (GTK_BOX(view), toolbar, FALSE, FALSE, 0);
- GtkToolItem* toolitem = gtk_tool_button_new (gtk_image_new_from_stock (GTK_STOCK_MISSING_IMAGE, GTK_ICON_SIZE_BUTTON), _("Update"));
- gtk_tool_item_set_expand (GTK_TOOL_ITEM(toolitem), TRUE);
- gtk_toolbar_insert (GTK_TOOLBAR(toolbar), toolitem, 0);
- g_signal_connect (toolitem, "clicked", G_CALLBACK(refresh_feeds_closure), view);
-
/*
* search/filter
*/
GtkWidget *hbox = gtk_hbox_new (FALSE, 0);
gtk_box_pack_start (GTK_BOX (view), hbox, FALSE, FALSE, 0);
+ GtkToolItem* toolitem = gtk_tool_button_new (gtk_image_new_from_stock (GTK_STOCK_MISSING_IMAGE, GTK_ICON_SIZE_BUTTON), _("Update"));
+ gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (toolitem), FALSE, FALSE, 0);
+ g_signal_connect (toolitem, "clicked", G_CALLBACK(refresh_feeds_closure), view);
+
view->search_toggle = gtk_toggle_button_new ();
gtk_box_pack_start (GTK_BOX (hbox), GTK_WIDGET (view->search_toggle), FALSE, FALSE, 0);
gtk_widget_set_name (GTK_WIDGET (view->search_toggle), "mokosearchbutton");
More information about the commitlog
mailing list