r2693 - in trunk/src/target/OM-2007/applications/openmoko-dialer: . src

njp at sita.openmoko.org njp at sita.openmoko.org
Mon Aug 13 12:19:56 CEST 2007


Author: njp
Date: 2007-08-13 12:19:54 +0200 (Mon, 13 Aug 2007)
New Revision: 2693

Modified:
   trunk/src/target/OM-2007/applications/openmoko-dialer/ChangeLog
   trunk/src/target/OM-2007/applications/openmoko-dialer/src/dialer-window-history.c
Log:
Check the string is valid before using strcmp.



Modified: trunk/src/target/OM-2007/applications/openmoko-dialer/ChangeLog
===================================================================
--- trunk/src/target/OM-2007/applications/openmoko-dialer/ChangeLog	2007-08-13 10:11:58 UTC (rev 2692)
+++ trunk/src/target/OM-2007/applications/openmoko-dialer/ChangeLog	2007-08-13 10:19:54 UTC (rev 2693)
@@ -0,0 +1,6 @@
+2007-08-13  Neil J. Patel  <njp at o-hand.com>
+
+	reviewed by: <delete if not using a buddy>
+
+	* src/dialer-window-history.c: (history_add_entry):
+

Modified: trunk/src/target/OM-2007/applications/openmoko-dialer/src/dialer-window-history.c
===================================================================
--- trunk/src/target/OM-2007/applications/openmoko-dialer/src/dialer-window-history.c	2007-08-13 10:11:58 UTC (rev 2692)
+++ trunk/src/target/OM-2007/applications/openmoko-dialer/src/dialer-window-history.c	2007-08-13 10:19:54 UTC (rev 2693)
@@ -686,7 +686,7 @@
   number = moko_journal_voice_info_get_distant_number (info);
     
   /* If the number is null, the number may have been stored in the summary*/
-  if (strcmp (number, "NULL") == 0) 
+  if (number == NULL || strcmp (number, "NULL") == 0) 
     number = moko_journal_entry_get_summary (j_entry);
   
   /* Load the correct icon */





More information about the commitlog mailing list