r3932 - branches/src/target/kernel/2.6.24.x/patches

werner at sita.openmoko.org werner at sita.openmoko.org
Wed Jan 23 02:02:53 CET 2008


Author: werner
Date: 2008-01-23 02:02:50 +0100 (Wed, 23 Jan 2008)
New Revision: 3932

Modified:
   branches/src/target/kernel/2.6.24.x/patches/gta01-vibrator.patch
Log:
vib-trashes-resume-fix.patch:

The resume stuff for vibrator was broken --> OOPS... I guess it was never
tested on GTA02 yet considering it did not have an active device associated
with the driver until today.  Fixed.

Signed-off-by: Andy Green <andy at openmoko.com>

gta01-vibrator.patch: 
- drivers/leds/leds-neo1973-vibrator.c (neo1973_vib_resume): resume after
  setting up the hardware, not before
- drivers/leds/leds-neo1973-vibrator.c (neo1973_vib_probe): don't forget to
  initialize platform data



Modified: branches/src/target/kernel/2.6.24.x/patches/gta01-vibrator.patch
===================================================================
--- branches/src/target/kernel/2.6.24.x/patches/gta01-vibrator.patch	2008-01-23 00:55:40 UTC (rev 3931)
+++ branches/src/target/kernel/2.6.24.x/patches/gta01-vibrator.patch	2008-01-23 01:02:50 UTC (rev 3932)
@@ -46,7 +46,7 @@
 ===================================================================
 --- /dev/null
 +++ linux-2.6.24-rc8/drivers/leds/leds-neo1973-vibrator.c
-@@ -0,0 +1,180 @@
+@@ -0,0 +1,181 @@
 +/*
 + * LED driver for the vibrator of the FIC Neo1973 GSM Phone
 + *
@@ -148,11 +148,11 @@
 +{
 +	struct neo1973_vib_priv *vp = platform_get_drvdata(dev);
 +
-+	led_classdev_resume(&neo1973_vib_led.cdev);
-+
 +	if (vp->has_pwm)
 +		neo1973_vib_init_hw(vp);
 +
++	led_classdev_resume(&neo1973_vib_led.cdev);
++
 +	return 0;
 +}
 +#endif /* CONFIG_PM */
@@ -170,6 +170,7 @@
 +		return -EIO;
 +
 +	neo1973_vib_led.gpio = r->start;
++	platform_set_drvdata(pdev, &neo1973_vib_led);
 +
 +	/* TOUT3 */
 +	if (neo1973_vib_led.gpio == S3C2410_GPB3) {





More information about the commitlog mailing list