Holger's qtopia repo: Changes to 'master'

git at git.openmoko.org git at git.openmoko.org
Thu Jul 3 21:08:14 CEST 2008


 etc/themes/finxi/callscreen.xml                    |    1 -
 etc/themes/finxi/callscreen_button.xml             |   29 -
 etc/themes/finxi/callscreen_keypad.xml             |   70 --
 etc/themes/finxi/callscreen_list.xml               |   70 --
 .../phone/callscreen/semithemed/callscreen.cpp     | 1169 +++++++-------------
 .../phone/callscreen/semithemed/callscreen.h       |  120 +-
 .../phonelauncher/phonelauncher_illume.cpp         |    9 +-
 7 files changed, 460 insertions(+), 1008 deletions(-)

New commits:
commit 9f6800463b7f06f52dfbc30a78ab22df2529a67e
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 21:03:11 2008 +0200

    [callscreen] Avoid a crash, fixing the real issue is still to do
        Get a call, make another one, join the two, split, use the menu
        to end the call => crash. Add a null check to avoid that.
    
        There are more bugs in the above scenario, I'm just fixing the
        crash here.

commit 493ce46269c9287d3421516257184be3e92da9ec
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 20:58:10 2008 +0200

    Revert "[callscreen] For the different views we will use different files"
    
    I have found a way to use the normal callscreen.xml and it seems to
    give the wanted effect. So splitting the callscreen up into multiple parts
    is not needed for now.
    
    This reverts commit 9ce4e6f8b36f4719bae3f259ac6d3fd169214ae7.
    
    Conflicts:
    
    	etc/themes/finxi/callscreen_button.xml
    	etc/themes/finxi/callscreen_keypad.xml
    	etc/themes/finxi/callscreen_list.xml

commit dd8684f676f94b9efe00c274c29a4646b5b77eb0
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 20:49:38 2008 +0200

    [callscreen] When toggling the keypad visibility the dtmf buttons cover the CellItemListView
        We get visual artefacts when having entered DTMF tones and then switching
        from keypad to none keypad. For some time the current DTMF strings is
        painted over the CellItemListView. Avoid this by moving the m_digits out of
        the theme control. Adjust the code as we know that m_digits is always
        around.

commit fa20c15ec78411d2e8546d52aa8dcefa0a0071f7
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 20:35:40 2008 +0200

    [callscreen] Move the theme handling into a separate class
        Move the actual theme loading and handling into a separate class. This will
        allow to create m_digits outside of the theme and use a proper layout on the
        callscreen.

commit 6f6dd8ade5317e61af71eb1c1ad1df37935f7016
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:57:26 2008 +0200

    [callscreen] Group the variables together by what they do

commit 68b3623bfc3c398a9c89e4e38b0e3ec7f579c8c2
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:45:41 2008 +0200

    [callscreen] Control the visibility of the dtmf digit entry with the theme file

commit 69a18460af2febae58899c4d00f10e70b37f4be0
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:43:02 2008 +0200

    [callscreen] Properly name the slot. We handle release of theme items here

commit 82cc97a225fcc10430f369e8c667d0f35ba8ec5e
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:41:55 2008 +0200

    [callscreen] Remove deadcode. It is in a public SCM nowadays no need to keep it around

commit 986186d339173e29f77ce328f5583443708810b2
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:40:01 2008 +0200

    [callscreen] It is flawed to make up items and add them to a weird layout
        If an item is not part of the callscreen cope with that. Add null
        checks for the m_digits and m_listView item. Do not create the QVBoxLayout
        as it would look really bad.

commit d2d3902d211a2b3cfdbe3f54dd12c63078d0986f
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:33:08 2008 +0200

    [callscreen] Remove the manualLayout invocations
        There is no need to do any kind of manual layout. Only on incoming
        and outgoing calls the keypad-box needs to be properly shown/hidden

commit 93cc3b89effadd8a81a59eaecb916cb1c9f235a0
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:26:57 2008 +0200

    [callscreen] Remove more unused stuff

commit ac53ff483204d50f570b4c19cf839ba9d6cd5747
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:24:22 2008 +0200

    [callscreen] Remove the #ifdefs as we will always use cell functionality

commit 9c4589ca77cf65a970b3c212431a4478a6d59b9f
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:21:53 2008 +0200

    [callscreen] Cleanup the initializer list  to make it more easy to add and remove stuff

commit fabc5710d1268f1c8f0d4df2ac0fd55be83b1681
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:20:07 2008 +0200

    [callscreen] Remove stuff we don't want. VideoWidget, Mouse LockScreen...
        Remove stuff we will never want to use in the callscreen. This includes
        a custom screenlock, the video widget for video ringtones...

commit 0a0fb0f07fac3a2db3c37e921004fb033fb026ae
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:15:35 2008 +0200

    [callscreen] Start removing unused functionality from the callscreen
        Start removing the really obsoleted things from the callscreen

commit e391626f56a4550d4f72613b0828b5af8554e154
Author: Holger Freyther <zecke at selfish.org>
Date:   Thu Jul 3 19:04:18 2008 +0200

    [callscreen] Start cleaning up by properly prefixing members
        Most of the replacement was done by sed but on a quick look
        it seems like I undid all changes to comments and user visible
        strings (e.g. action is a good candidate for mistakes)





More information about the commitlog mailing list