r4676 - developers/werner/wlan-spi/patches

[werner at docs.openmoko.org]

Author: werner
Date: 2008-09-28 03:42:31 +0200 (Sun, 28 Sep 2008)
New Revision: 4676

Modified:
   developers/werner/wlan-spi/patches/tweak-spi.patch
Log:
Updated description of the SPI module's problems. They're not as grim as
the older comment suggested.



Modified: developers/werner/wlan-spi/patches/tweak-spi.patch
===================================================================
--- developers/werner/wlan-spi/patches/tweak-spi.patch	2008-09-28 00:37:32 UTC (rev 4675)
+++ developers/werner/wlan-spi/patches/tweak-spi.patch	2008-09-28 01:42:31 UTC (rev 4676)
@@ -9,8 +9,8 @@
 
 Index: korig/drivers/spi/spi_s3c24xx.c
 ===================================================================
---- korig.orig/drivers/spi/spi_s3c24xx.c	2008-09-27 11:28:42.000000000 -0300
-+++ korig/drivers/spi/spi_s3c24xx.c	2008-09-27 11:29:40.000000000 -0300
+--- korig.orig/drivers/spi/spi_s3c24xx.c	2008-09-27 21:32:30.000000000 -0300
++++ korig/drivers/spi/spi_s3c24xx.c	2008-09-27 22:27:20.000000000 -0300
 @@ -198,6 +198,27 @@
  	writeb(hw_txbyte(hw, 0), hw->regs + S3C2410_SPTDAT);
  	wait_for_completion(&hw->done);
@@ -39,7 +39,7 @@
  	return hw->count;
  }
  
-@@ -233,8 +254,23 @@
+@@ -233,8 +254,19 @@
  
  	hw->count++;
  
@@ -49,12 +49,8 @@
 +	 * Misfeature #1: the first byte received can only be read after
 +	 * writing the second byte to send to the shifter.
 +	 *
-+	 * Misfeature #2: we need to consume all data received.
-+	 *
-+	 * Oddly enough,  it's not sufficient if we do a large number of SPRDAT
-+	 * reads before or right after starting the transmission. We really
-+	 * have to fetch a byte for each byte we send, or the SPI engine gets
-+	 * upset.
++	 * Misfeature #2: we need to consume the byte preceding the first byte
++	 * or the SPI engine gets upset.
 +	 */
 +	if (hw->rx) {
 +		u8 b = readb(hw->regs + S3C2410_SPRDAT);
@@ -67,8 +63,8 @@
  
 Index: korig/arch/arm/mach-s3c2440/mach-gta02.c
 ===================================================================
---- korig.orig/arch/arm/mach-s3c2440/mach-gta02.c	2008-09-27 11:29:48.000000000 -0300
-+++ korig/arch/arm/mach-s3c2440/mach-gta02.c	2008-09-27 11:30:13.000000000 -0300
+--- korig.orig/arch/arm/mach-s3c2440/mach-gta02.c	2008-09-27 21:32:30.000000000 -0300
++++ korig/arch/arm/mach-s3c2440/mach-gta02.c	2008-09-27 21:32:30.000000000 -0300
 @@ -1239,7 +1239,7 @@
  static struct spi_board_info gta02_spi_mmc_bdinfo = {
  	.modalias	= "mmc_spi",