r5557 - trunk/eda/fped

werner at docs.openmoko.org werner at docs.openmoko.org
Thu Aug 27 16:24:54 CEST 2009


Author: werner
Date: 2009-08-27 16:24:54 +0200 (Thu, 27 Aug 2009)
New Revision: 5557

Modified:
   trunk/eda/fped/TODO
   trunk/eda/fped/fpd.y
Log:
Cause in TODO, effect:

- pad type wasn't optional



Modified: trunk/eda/fped/TODO
===================================================================
--- trunk/eda/fped/TODO	2009-08-27 10:59:51 UTC (rev 5556)
+++ trunk/eda/fped/TODO	2009-08-27 14:24:54 UTC (rev 5557)
@@ -36,6 +36,8 @@
 - whenever we call parse_* for input parsing, we may leak lots of expressions
 - can't edit measurement labels through the GUI
 - unbalanced parentheses in text throw off Postscript syntax
+- when starting, Gtk+ may issue many "extension [...] missing" warnings, which
+  can (and did) hide warnings about real problems
 
 Code cleanup:
 - merge edit_unique with edit_name

Modified: trunk/eda/fped/fpd.y
===================================================================
--- trunk/eda/fped/fpd.y	2009-08-27 10:59:51 UTC (rev 5556)
+++ trunk/eda/fped/fpd.y	2009-08-27 14:24:54 UTC (rev 5557)
@@ -512,14 +512,19 @@
 	;
 
 pad_type:
-	ID
 		{
+			$$ = pt_normal;
+		}
+	| ID
+		{
 			if (!strcmp($1, "bare"))
 				$$ = pt_bare;
 			else if (!strcmp($1, "paste"))
 				$$ = pt_paste;
-			else
-				$$ = pt_normal;
+			else {
+				yyerrorf("unknown pad type \"%s\"", $1);
+				YYABORT;
+			}
 		}
 	;
 




More information about the commitlog mailing list