Optimization team update (11/23 ~ 11/29)

John Lee john_lee at openmoko.com
Tue Dec 2 15:45:17 CET 2008


On Tue, Dec 02, 2008 at 07:50:58PM +0900, William Kenworthy wrote:
> On Mon, 2008-12-01 at 22:22 +0900, William Kenworthy wrote:
> > Thanks, also I was bit too rushed.  I shut down X which allowed me to
> ....
> > 
> > Fonts and widgets are far too large on apps like pythm, tangogps and the
> > like.
> > 
> ...
> 
> Fixed by adding the gtkrc fix from FDOM
> 
> Should I raise a bug for this - I think it is an old issue (as evidenced
> by the fact that FDOM has had the fix for awhile)
> 
> BillK

Please do since I couldn't find it in trac.  Here is the diff between the
old gtkrc from moko-gtk-engine and the one from FDOM:

$ diff -urN gtkrc /home/john/tmp/FDOMizer/fixes/gtkrc 
--- gtkrc	2008-10-30 18:42:30.000000000 +0800
+++ /home/john/tmp/FDOMizer/fixes/gtkrc	2008-10-19 16:12:35.000000000 +0800
@@ -12,6 +12,12 @@
 gtk-button-images = 0
 gtk-menu-images = 0
 gtk-icon-sizes = "gtk-button=32,32:gtk-small-toolbar=48,48:gtk-large-toolbar=48,48"
+gtk-font-name = "Sans 4"
+gtk-icon-theme-name="openmoko-standard"
+gtk-toolbar-icon-size = GTK_ICON_SIZE_SMALL_TOOLBAR
+
+
+
 
 # Set the default gtk-color-scheme property
 gtk_color_scheme = "fg_color:#fff;bg_color:#333;base_color:#aaa;text_color:#000;selected_bg_color:#ff7d00;selected_fg_color:#000"
@@ -182,10 +188,10 @@
 }
 widget "*.mokosearchbutton" style "mokosearchbutton"
 
-include "matchboxpanel"
-include "openmoko-calculator"
-include "openmoko-contacts"
-include "openmoko-dialer"
-include "openmoko-panel-plugins"
-include "openmoko-mediaplayer"
+include "/usr/share/themes/Moko/gtk-2.0/matchboxpanel"
+include "/usr/share/themes/Moko/gtk-2.0/openmoko-calculator"
+include "/usr/share/themes/Moko/gtk-2.0/openmoko-contacts"
+include "/usr/share/themes/Moko/gtk-2.0/openmoko-dialer"
+include "/usr/share/themes/Moko/gtk-2.0/openmoko-panel-plugins"
+


I don't have enough knowledge to comment on it.  The second section
seems strange to me though, because it assumes files will be installed
to /usr/share/themes/Moko/gtk-2.0/ while this should really be decided
by autotools.

Could someone please review it?  If it's okay I'm going to apply it to
svn.


- John




More information about the community mailing list