[om2009] shr-settings like ? usability ?

[Risto H. Kurppa]

On Wed, Jul 1, 2009 at 4:10 AM, Xavier Cremaschi<omega.xavier at gmail.com> wrote:
> Btw 'People' application needs to be fixed...
>
> For whom it may concern, in
> /usr/lib/python2.6/site-packages/tichy/gui_paroli/__init__.py", line
> 288, in _redraw_view
> the line
>     letter = value[0]
> triggers an error.
>
> If you read the code, you will see something like :
>     if hasattr(item, attribute):
>         value = getattr(item, attribute)
>         if isinstance(value, str) and not len(value):
>             value = " " #bugfix for empty name
>         if self.LetterDict:
>             if self.label_list.index((part, attribute)) == 0:
>                 letter = value[0]
>
>
> This code fails is 'value' is None, which is its value in my specific
> case indeed.
>
> I tried an ugly modification :
>     if hasattr(item, attribute):
>         value = getattr(item, attribute)
>         if value == None:
>             value = " "
>         if isinstance(value, str) and not len(value):
>             value = " " #bugfix for empty name
>         if self.LetterDict and len(value):
>             if self.label_list.index((part, attribute)) == 0:
>                 letter = value[0]

Great, thanks for this!

I hope someone (=laszlo:) will implement this fix soon.

r