Patch for libphone-ui [was: fails to call from contacts if phone# contains any non-number?]

Yaroslav Halchenko site-openmoko.org at onerussian.com
Tue Jun 22 20:57:43 CEST 2010


Hi Everyone,

Could you please overview and accept following patches (1 is non
functional which I've sent to Klaus yesterday).  patch should remove any
symbol from the number before sending the query to initiate the call...

I don't have chain ready to build it for phone, but built fine on
desktop so should be fine? ;)  Also I am not sure if location of
phone # filtering is the best , and it would be great if similar would
be adopted for matching numbers in the phone calls log book.

Thanks in advance

On Mon, 21 Jun 2010, Yaroslav Halchenko wrote:

> Hi guys,

> It has been a while since I've been observing this but finally decided
> to email after the last upgrade today.

> I have my contacts synced from gmail using PISI (Thank you Michael), I
> am using SHR, and I have somewhat a variety of formats for numbers
> specifications, e.g.

> 2345678900
> (234) 567-8900
> +1 (234) 567-8900

> etc

> the problem is, that it seems that  if there is any non-digit in the
> phone #, it fails to actually initiate the call. e.g. here is example --
> I've called contact with only numbers in phone #, then added a space
> after 1 - and it failed to call:
-- 
                                  .-.
=------------------------------   /v\  ----------------------------=
Keep in touch                    // \\     (yoh@|www.)onerussian.com
Yaroslav Halchenko              /(   )\               ICQ#: 60653192
                   Linux User    ^^-^^    [175555]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ENH-non-functional-tabs-Initi-t-ating-spelling.patch
Type: text/x-diff
Size: 5032 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/community/attachments/20100622/45c03296/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ENH-adding-filtering-of-phone-off-illegal-symbols-be.patch
Type: text/x-diff
Size: 2379 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/community/attachments/20100622/45c03296/attachment-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.openmoko.org/pipermail/community/attachments/20100622/45c03296/attachment.pgp 


More information about the community mailing list