Patch for libphone-ui [was: fails to call from contacts if phone # contains any non-number?]

Fox Mulder Quakeman1 at
Tue Jun 29 20:53:22 CEST 2010

Am 22.06.2010 20:57, schrieb Yaroslav Halchenko:
> Hi Everyone,
> Could you please overview and accept following patches (1 is non
> functional which I've sent to Klaus yesterday).  patch should remove any
> symbol from the number before sending the query to initiate the call...
> I don't have chain ready to build it for phone, but built fine on
> desktop so should be fine? ;)  Also I am not sure if location of
> phone # filtering is the best , and it would be great if similar would
> be adopted for matching numbers in the phone calls log book.

I sent your patches to Tom Hacohen who seems to be responsible for this
area. He hasn't subscribed this list so i will forward his answer here:

Am 29.06.2010 20:23, schrieb Tom Hacohen:
> Mind doing me a favor? Please tell him thanks, but I have two
> comments:
> 1. He should send his shr patches to shr-devel.
> 2. His patch for filtering bad input is bad, as it should be done in
> libphone-utis and not in libphone-ui*
> We don't want UI filtering, but we want backend system filtering. The
> correct thing will be fixing libphone-utils,
> adding "filter before sms, filter before call, etc" functions and
> using them in FSO, not in the UI.
> Thanks in advance, will hopefully do it in the weekend.

I added Tom in CC so maybe you want to contact him yourself. :)

More information about the community mailing list