Patch for libphone-ui [was: fails to call from contacts if phone # contains any non-number?]

Yaroslav Halchenko at
Wed Jun 30 05:03:34 CEST 2010

Hi Fox -- Thank you very much for forwarding and thank you Tom for
reply!  Indeed location felt suboptimal even for me (as I wrote "Also I
am not sure if location of phone # filtering is the best"), but I am
quite ignorant in SHR internal structure, so please take it as my
'excuse' ;)

Just a note: another location for such filtering would be before
matching phone #s from the book with those in call log.

Please let me know if I could be of any help, Tom.  Thanks in advance
for pushing this feature through.


On Tue, 29 Jun 2010, Fox Mulder wrote:
> Am 22.06.2010 20:57, schrieb Yaroslav Halchenko:
> > Hi Everyone,

> > Could you please overview and accept following patches (1 is non
> > functional which I've sent to Klaus yesterday).  patch should remove any
> > symbol from the number before sending the query to initiate the call...

> > I don't have chain ready to build it for phone, but built fine on
> > desktop so should be fine? ;)  Also I am not sure if location of
> > phone # filtering is the best , and it would be great if similar would
> > be adopted for matching numbers in the phone calls log book.

> I sent your patches to Tom Hacohen who seems to be responsible for this
> area. He hasn't subscribed this list so i will forward his answer here:

> Am 29.06.2010 20:23, schrieb Tom Hacohen:
> > Mind doing me a favor? Please tell him thanks, but I have two
> > comments:
> > 1. He should send his shr patches to shr-devel.
> > 2. His patch for filtering bad input is bad, as it should be done in
> > libphone-utis and not in libphone-ui*

> > We don't want UI filtering, but we want backend system filtering. The
> > correct thing will be fixing libphone-utils,
> > adding "filter before sms, filter before call, etc" functions and
> > using them in FSO, not in the UI.

> > Thanks in advance, will hopefully do it in the weekend.

> I added Tom in CC so maybe you want to contact him yourself. :)

> _______________________________________________
> Openmoko community mailing list
> community at

=------------------------------   /v\  ----------------------------=
Keep in touch                    // \\     (yoh@|www.)
Yaroslav Halchenko              /(   )\               ICQ#: 60653192
                   Linux User    ^^-^^    [175555]

More information about the community mailing list