qi: use "\r\n" in serial console?
Timo Juhani Lindfors
timo.lindfors at iki.fi
Thu Jun 23 14:15:11 CEST 2011
Hi,
if I use "picocom -b 115200 /dev/ttyUSB0" to see the boot messages of Qi
and kernel I see that the Qi lines are terminated with "\n" while Linux
uses "\r\n" [1].
Are you using something else than picocom or avoiding the problem in
some other way? If not, should it be fairly safe to add
diff --git a/src/cpu/s3c2442/gta02.c b/src/cpu/s3c2442/gta02.c
index 13be2ac..6dc1208 100644
--- a/src/cpu/s3c2442/gta02.c
+++ b/src/cpu/s3c2442/gta02.c
@@ -458,6 +458,8 @@ const struct board_variant const *
get_board_variant_gta02(void)
static __attribute__ (( section (".steppingstone") )) void
putc_gta02(char c)
{
+ if (c == '\n')
+ serial_putc_s3c24xx(GTA02_DEBUG_UART, '\r');
serial_putc_s3c24xx(GTA02_DEBUG_UART, c);
}
or is there some trouble to be expected?
best regards,
Timo Lindfors
[1] Example output:
Qi Bootloader s3c2442 wallwart debian_20100105-1~unrelease0
2011-06-06T08:29:17+0000 Copyright (C) 2008 Openmoko, Inc.
Detected: Freerunner / GTA02, A6 PCB
Battery condition reasonable
Trying kernel: SD Card EXT2 P1 Kernel
Card Type: SD 2.0 SDHC / Mfr: 0x02, OEM "TM" / SA08G", rev 0.6 / s/n: 576236754 / date: 12/2010
SDHC size: 7592 MiB
Partition: 1 start +52 512-byte blocks, size 16 MiB
EXT2 open: boot/noboot-GTA02 Open failed
EXT2 open: boot/append-GTA02 OK
EXT2 open: boot/uImage-GTA02.bin OK
Found: "3f4c7e4fa3d937a8"
Size: 1726 KiB
EXT2 open: boot/uImage-GTA02.bin OK
** skipping
Read failed
bad magic 66346537
Trying kernel: SD Card EXT2 P2 Kernel
Partition: 2 start +33072 512-byte blocks, size 3867 MiB
EXT2 open: boot/noboot-GTA02 Open failed
EXT2 open: boot/append-GTA02 OK
EXT2 open: boot/uImage-GTA02.bin OK
Found: "Debian FreeRunner Kernel"
Size: 2148 KiB
EXT2 open: boot/uImage-GTA02.bin OK
Cmdline: loglevel=4 console=tty0 console=ttySAC2,115200 init=/sbin/init ro mtdparts=physmap-flash:-(nor);neo1973-nand:0x00040000(qi),0x00040000(depr-ub-env),0x00800000(kernel),0x000a0000(depr),0x00040000(identity-ext2),0x0f6a0000(rootfs) g_ether.dev_addr=00:1F:11:01:62:8A g_ether.host_addr=00:1F:11:01:62:8B root=/dev/mmcblk0p2 rootdelay=1 rootdelay=1 c8008080, irq 35
[ 0.280000] DMA channel 3 at c80080c0, irq 36
[ 0.280000] S3C244X: Clock Support, DVS off
[ 0.290000] s3c-adc s3c24xx-adc: attached adc driver
[ 0.290000] s3c24xx-pwm s3c24xx-pwm.0: tin at 25000000, tdiv at 25000000, tin=divclk, base 0
[ 0.300000] s3c24xx-pwm s3c24xx-pwm.1: tin at 25000000, tdiv at 25000000, tin=divclk, base 8
More information about the community
mailing list