[oe] [PATCH] Fix compilation of Openembedded on ppc64
Koen Kooi
k.kooi at student.utwente.nl
Tue Dec 9 13:42:04 CET 2008
On 09-12-08 13:07, Michael 'Mickey' Lauer wrote:
> Am Tuesday 09 December 2008 11:43:30 schrieb Koen Kooi:
>> On 09-12-08 11:02, Michael 'Mickey' Lauer wrote:
>>> sent to org.oe.dev, thanks.
>> Could you please fix the commit message next time?
>
> Do you really think it's worth it?
Yes
> Not a strong opinion here, but this kind of
> destroys the elegant workflow with 'git am'
git-am foo.eml ; git commit --amend
or
vi foo.eml ; git am foo.eml
or
patch -p1 < foo.eml ; git commit -a --author "foo bar <foo at bar>"
git-am should only be used for patches that are 100% correct, if they
aren't, fixup is needed.
> and I think we should relax the policy for patches we receive by mail.
You can ask the person to resubmit the patch with a proper message (it's
not that hard) or fix the message yourself when applying it (not that
hard either).
Creating a loop-hole for mailed-in patches would be madness since people
will start to abuse it ("the rules don't apply to emailed patches").
regards,
Koen
More information about the devel
mailing list