[patch] Number matching support

Holger Freyther zecke at openmoko.org
Mon Jul 21 12:22:02 CEST 2008

On Saturday 19 July 2008 20:34:11 Joachim Breitner wrote:
> Hi
> I have added (seemingly) complete support for matching human-written
> phone number (07032/123 456) in the phone book or when dialing, instead
> of just dumb string comparison, in both openmoko-dialer2 and
> openmoko-messages2. The latter required a small, non-obstrusive change
> to eds and libjana. The related bug report is
> https://docs.openmoko.org/trac/ticket/1606
> Please consider applying these git patches, which are against the
> org.openmoko.dev branch, or otherwise tell my what needs to be changed
> that they can be applied.

I had hoped someone else, more qualified would step up. I think the issues you 
bring up are.

1. Who is reading the bug report and acking it?
2. Who is reviewing patches and landing them?
3. Who makes sure people get updated packages?

1. I don't think we have anyone in Taipei responsible for going through 
incoming OM2007.2 bugs yet. I know that Tony was asked to start organizing 
support though. Yeah, I'm well aware how this sounds. :)
Sometimes I go through the bugs....but I'm more than busy with ASU.

2. Most of OM2007.2 was done by o-hand.com and the contract with them on that 
ended (to the best of my knowledge). So we can not ask them to fix/handle 
these kind of bugs, we can do this on a private developer developer base 
though. We can ask erin but these patches are tricky.

3. I don't know if XorA feels responsible for providing upgraded packages? If 
opkg upgrade from factory to image to the latest .dev build is working at 
all. I know that for ASU that this will be a task for the distro team 
(Julian, Graeme, me).

So my take:

So I still hope for someone else to play bugmaster and manage, triage the 
incoming bug reports as my workload is already incredible high. Let's see if 
I can talk brenda into playing our bugmaster as well... 

Patch review. Certainly all the three/four touched components are not in my 
area of expertise. I'm a trained monkey/reviewer at webkit.org and we have 
quite strict coding style guidelines[1]. But I try to ignore these for now.

	Comparing numbers will only work if they are exact matches or have at least 
seven numbers? Where is that seven coming from?

	Can we somehow avoid the duplication of this code? Can we move the matching 
somewhere else? Can we move the matching code into an evolution library (if 
that exists)?
	Some more comments would be cool.

	You added patches for OpenEmbedded. Personally I would prefer if these things 
could end up upstream. And at this state it might makes sense to talk to Ross 
and Chris from o-hand.com as they work on evolution and control libjana....

So we can put the patches to Openmoko apps into the Openmoko repository (after 
cleaning the code a bit). Then we still would have libjana and eds to go, 
which we could patch in the metadata. But I would really feel a lot better if 
we would add the numbering comparing only once... any ideas where such a 
place could be?

No idea.

I wish I had better news.

kind regards

[1] http://webkit.org/coding/coding-style.html

More information about the devel mailing list