u-boot fix to charge empty battery

Philipp Hug debian at hug.cx
Thu Oct 9 03:56:32 CEST 2008


> Are you sure ? According to the PCF50633 manual,
>
> - the behaviour when setting BVMCTL.bvmlvl = 0 is unspecified [1],
>   and
> - Vbat is only considered if OOCCTL.usbbatchk = 1 [2], which is
>   neither the NoPower default nor what u-boot sets [3]. The kernel
>   doesn't touch OOCCTL either.
>
> [1] 8.5.5, table 37
> [2] 8.5.6, second to last paragraph, and also 8.1.5, table 13
> [3] http://git.openmoko.org/?p=u-boot.git;a=blob;f=board/neo1973/gta02/pcf50633.c;h=69d7fb05ad4dfb57f499235986e6ce7e64b45270;hb=stable
>
> - Werner
>   

You're completely right, the settings should be correct. I changed it
back to 0x02 and my patch still worked.

I think it's a lot simpler:

-               /* we have plenty of external power -> try to boot */
-               if (pcf50633_usb_last_maxcurrent >= 500)
-                    break

This causes u-boot to try to continue with the boot process and I guess
the neo uses more > 500mA and the PMU shuts it down.
Does this make more sense?

Philipp





More information about the devel mailing list