u-boot: charging patch

Andy Green andy at openmoko.com
Sun Jan 11 12:40:10 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Somebody in the thread at some point said:
| philipp at hug.cx writes:
|> diff --git a/board/neo1973/gta02/gta02.c b/board/neo1973/gta02/gta02.c
|> index a59a513..4255caa 100644
|> --- a/board/neo1973/gta02/gta02.c
|> +++ b/board/neo1973/gta02/gta02.c
|> @@ -322,6 +322,11 @@ static void set_revision(void)
|>
|>  static void poll_charger(void)
|>  {
|> +	/* charge with at least 100 mA otherwise dumb chargers won't work*/
|> +	if (udc_usb_maxcurrent < 100) {
|> +		udc_usb_maxcurrent = 100;
|> +	}
|> +
|
| Disclamer: I am not an u-boot developer :-)
|
| Shouldn't this be configurable? We already have a command for enabling
| 500mA charging so why not add a command to enable 100mA charging too?
|
| "neo1973 charger fast - enable fast (500mA) charging\n"

I can see the logic, but why in U-Boot?  Are people really sitting in
U-Boot and need more commands for stuff like charging?

- -Andy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAklp2poACgkQOjLpvpq7dMrDOwCfTPG9GuMrDG30q29b2wvz8V+I
RUgAninr5EVXIWKX5w5bKlEZ7UjIl7ZI
=NOLC
-----END PGP SIGNATURE-----



More information about the devel mailing list