[PATCH 1/2] dfu_file.c: Add parsing of DFU file suffix

Stefan Schmidt stefan at datenfreihafen.org
Fri May 27 22:40:40 CEST 2011


On Wed, 2011-05-25 at 08:37, Stefan Schmidt wrote:
> On Tue, 2011-05-24 at 23:07, Tormod Volden wrote:
> > From: Tormod Volden <debian.tormod at gmail.com>
> > 
> > The new dfu_file structure is used to keep track of the download (or
> > upload) file. parse_dfu_suffix() will parse an (already opened) file and
> > populate the struct members corresponding to the DFU suffix fields.
> > 
> > The commit also includes some verification of the suffix fields,
> > but at this point only warns about mismatches, with one exception:
> > If there is a valid DFU suffix, it must have DFU revision 1.0,
> > otherwise we abort the download.
> > 
> > Signed-off-by: Tormod Volden <debian.tormod at gmail.com>
> > ---
> > 
> > The patches are also available for review or pull at:
> > https://gitorious.org/~tormod/unofficial-clones/dfuse-dfu-util/commits/libusb-1.0-patches
> Looks good now from a review. Will apply it later today after some
> testing. Maybe using the repo to pull directly.

I merged these three commits from your git branch now. Works nicely
for me.

I also added a suffix to firmware files and tested it against your
code. Parsing works nicely. On top of this I have a first version for
the CRC checking hacked up. Need to clean it up (just hacked in bed
before sleeping) though.

Stefan Schmidt

More information about the devel mailing list