[PATCH 6/6 v2] main: Rename MAX_STR_LEN and bump it to 253

Tormod Volden lists.tormod at gmail.com
Tue Sep 6 21:06:20 CEST 2011


On Tue, Sep 6, 2011 at 7:48 PM, Stefan Schmidt wrote:
> What is the char count for the strings you get with the Dfuse device?
> Must be over 64 for sure as you hit this limitation, but are also over
> 128?

The Dfuse devices have no fixed length on this string, it depends on
the complexity of the memory map. With many memory segments the string
can theoretically get long. Future devices might have lots of memory
banks. The bootloader itself (if in flash) will typically mark its own
code location as read-only segments, and so on.

> Anyway, keeping those bytes for compat sounds like a good enough
> reason for me. Applied.

Yes, I prepared it for the worst case. No reason to pick an arbitrary
limit like 64 or 128. This macro may be used for any USB descriptor
string and I have not seen any limit on them other than the one I
deduced.

Thanks for reviewing all the patches!

Tormod



More information about the devel mailing list