[PATCH 4/4 dfu-util] main: Always retrieve the DFU functional descriptor

Stefan Schmidt stefan at datenfreihafen.org
Sat Sep 17 18:40:12 CEST 2011


On Thu, 2011-09-15 at 22:08, Tormod Volden wrote:
> From: Tormod Volden <debian.tormod at gmail.com>
> It should exist both in run-time and DFU mode, and should
> report the transfer size.
> Also print out the device DFU version as reported by the functional
> descriptor. For DFU 1.0 devices the descriptor does not contain
> the version field, so set it to 1.00 if the field is missing.
> Signed-off-by: Tormod Volden <debian.tormod at gmail.com>
> ---
> I am pretty sure all supported devices return this descriptor? So
> we can bail out if we can't retrieve it.

Sadly this seems not to be the case. I gave this one a spin and it
broke several devices for me. :(

I don't have time to debug this the next days but should hopefully be
able to do it end of next week. So I applied all but this patch from
the series.

> The program banner announces it only supports DFU 1.0 but the fact is
> that it uses a few 1.1-only features. We should try to cover both in
> the long run, and I think we should also follow the standard strictly,
> and rather add device-specific quirks if needed.

I agree that we should support both in the long term. Could you
refresh my mind what 1.1 features we are using currently? I was under
the impression we don't.

Stefan Schmidt

More information about the devel mailing list