[PATCH] teach gsmd to handle CMS error messages
laforge at openmoko.org
Wed Mar 28 13:39:48 CEST 2007
Thanks for your patch, Philipp.
On Tue, Mar 27, 2007 at 06:04:51PM +0200, Philipp Zabel wrote:
> Current gsmd doesn't handle CMS error messages, thinking they are
> extended replies and getting totally confused because it doesn't count
> them as final results. The following patch adds CMS error definitions
> from ETSI TS 07.05 and handles those errors in atcmd.c's ml_parse().
Ok, I haven't yet looked at SMS support. Your patch looks fine, though
- and thus I'll commit it now.
> Question: is parse_final_result obsolete or is it only unused currently
> but will handle the final results in the future?
it is not obsolete. Once multi-line response parsing is in place, this
will look cleaner.
- Harald Welte <laforge at openmoko.org> http://openmoko.org/
Software for the world's first truly open Free Software mobile phone
More information about the gsmd-devel