gsmd patch, was Re: [patch] modify some functions for phonebook
tick at openmoko.com
Tue Nov 20 10:04:53 CET 2007
-----BEGIN PGP SIGNED MESSAGE-----
Thanks for pointing out the two bugs.
R3451 has fixed them.
andrzej zaborowski 提到:
> On 18/10/2007, Erin Yueh <erin_yueh at openmoko.com> wrote:
>> andrzej zaborowski wrote:
>>> Erin Yueh: [patch] enable CPHS and retrieve voicemail number from SIM
>>> I have searched and I couldn't find the documentation for AT%CPMB and
>>> AT%CPHS commands anywhere - what document are they from (please insert
>>> comments like in other places in gsmd, e.g. "Refer to GSM 03.40,
>>> chapter X.Y.Z"). If they are TI Calypso specific they should sit in
>>> the vendor plugin.
>> Yes, they are TI Calypso specific commands, and i put them in vendor
> Oops, sorry I must be blind. I was confused because I wanted to add a
> less cryptic comment than "%CPHS: enable CPHS functionalities".
> The patch applies cleanly and in the
> http://folks.o-hand.com/andrew/gsmd.git tree it has commit id
> 175bcf4f2ac0fa33c9392b8d1225e4544678f02c. I slightly changed the cpmb
> callback because rc could be used uninitialised.
> I also added another patch (id
> b16cf25878d0cb70cf8e06f01cff3363819d31cb) that simplifies csq_parse()
> in vendor_ti.c and avoids using strtok() on a constant string (illegal
> according to the manual).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1831 bytes
Desc: not available
Url : http://lists.openmoko.org/pipermail/gsmd-devel/attachments/20071120/7c6c8cd9/rc_and_avoid_strtok.bin
More information about the gsmd-devel