gsmd patch, was Re: [patch] modify some functions for phonebook

andrzej zaborowski balrogg at
Thu Oct 18 16:33:31 CEST 2007


On 18/10/2007, Erin Yueh <erin_yueh at> wrote:
> andrzej zaborowski wrote:
> > [......]
> >
> > Erin Yueh: [patch] enable CPHS and retrieve voicemail number from SIM card
> > I have searched and I couldn't find the documentation for AT%CPMB and
> > AT%CPHS commands anywhere - what document are they from (please insert
> > comments like in other places in gsmd, e.g. "Refer to GSM 03.40,
> > chapter X.Y.Z"). If they are TI Calypso specific they should sit in
> > the vendor plugin.
> >
> >
> Yes, they are TI Calypso specific commands, and i put them in vendor plugin.

Oops, sorry I must be blind. I was confused because I wanted to add a
less cryptic comment than "%CPHS: enable CPHS functionalities".

The patch applies cleanly and in the tree it has commit id
175bcf4f2ac0fa33c9392b8d1225e4544678f02c. I slightly changed the cpmb
callback because rc could be used uninitialised.

I also added another patch (id
b16cf25878d0cb70cf8e06f01cff3363819d31cb) that simplifies csq_parse()
in vendor_ti.c and avoids using strtok() on a constant string (illegal
according to the manual).


More information about the gsmd-devel mailing list